Integrate shellcheck into PR checks

[brooke-hamilton]

Area for Improvement

Shellcheck is a static analysis tool for bash scripts. It has a good VS Code extension, which is being incorporated into our dev container with PR #7963. Let's include shellcheck into our PR checks.

Observed behavior

No response

Desired behavior

• All existing scripts are validated with shellcheck, with all issues resolved or suppressed.
• Shellcheck is executed on all bash scripts as a build validation.
• Contributing documentation is updated to explain how to install and run shell check. (The easy path is for contributors to use the dev container.)

Proposed Fix

No response

rad Version

N/A

Operating system

No response

Additional context

No response

Would you like to support us?

• Yes, I would like to support you

AB#13572

[radius-triage-bot]

👋 @brooke-hamilton Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

[radius-triage-bot]

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview