Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build and PR validation workflow to build the dev container #8013

Open
1 task
brooke-hamilton opened this issue Oct 23, 2024 · 2 comments
Open
1 task
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged

Comments

@brooke-hamilton
Copy link
Contributor

brooke-hamilton commented Oct 23, 2024

Area for Improvement

The dev container is our standardized engineering environment. It is subject to dependabot upgrades, changes to platform dependencies, and configuration changes due to evolving software development needs. We therefore need an automated PR validation build and a weekly scheduled build to ensure that the container continues to function as expected.

Observed behavior

Currently, the dev container is tested manually by running a local dev container build.

Desired behavior

We need a dev container build workflow that validates that the dev container can be built and that it functions as expected.

Proposed Fix

The dev container build should do the following using the devcontainer CLI:

  • Build the container image.
  • Launch the container.
  • Run a representative MAKE command within the container, e.g. make build lint to act as a validation test.

rad Version

N/A

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#13503

@brooke-hamilton brooke-hamilton added the maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. label Oct 23, 2024
@radius-triage-bot
Copy link

👋 @brooke-hamilton Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@lakshmimsft lakshmimsft added the triaged This issue has been reviewed and triaged label Oct 24, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged
Projects
None yet
Development

No branches or pull requests

2 participants