Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Azure Workload Identity in functional test runs #7715

Closed
1 task done
willdavsmith opened this issue Jun 24, 2024 · 3 comments · Fixed by #7787
Closed
1 task done

Use Azure Workload Identity in functional test runs #7715

willdavsmith opened this issue Jun 24, 2024 · 3 comments · Fixed by #7787
Labels
important This item is a high priority Issue we intend to address as soon as possible maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged

Comments

@willdavsmith
Copy link
Contributor

willdavsmith commented Jun 24, 2024

Area for Improvement

Today, we use service principal auth for our functional tests. We should migrate to Azure Workload Identity now that it's supported in Radius.

Observed behavior

No response

Desired behavior

  • Radius functional tests use Azure Workload Identity

Proposed Fix

No response

rad Version

0.35.0

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#12620

@willdavsmith willdavsmith added the maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. label Jun 24, 2024
@radius-triage-bot
Copy link

👋 @willdavsmith Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@sylvainsf sylvainsf added triaged This issue has been reviewed and triaged important This item is a high priority Issue we intend to address as soon as possible labels Jun 24, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@radius-triage-bot
Copy link

We've prioritized work on this issue. Please subscribe to this issue for notifications, we'll provide updates as we make progress.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

superbeeny pushed a commit to superbeeny/radius that referenced this issue Aug 14, 2024
…h in functional tests (radius-project#7787)

# Description

* Switch Azure SP auth to WI in functional tests
* Fix issue with Azure WI + application WI in applications-rp
* Fix issue with Azure WI in terraform
* Adding `workflow-dispatch` triggers

Example successful workflow:
https://github.com/radius-project/radius/actions/runs/10311808492

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#7715

---------

Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: Will Smith <[email protected]>
Reshrahim pushed a commit to Reshrahim/radius that referenced this issue Aug 27, 2024
…h in functional tests (radius-project#7787)

# Description

* Switch Azure SP auth to WI in functional tests
* Fix issue with Azure WI + application WI in applications-rp
* Fix issue with Azure WI in terraform
* Adding `workflow-dispatch` triggers

Example successful workflow:
https://github.com/radius-project/radius/actions/runs/10311808492

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#7715

---------

Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: Will Smith <[email protected]>
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important This item is a high priority Issue we intend to address as soon as possible maintenance Issue is a non-user-facing task like updating tests, improving automation, etc.. triaged This issue has been reviewed and triaged
Projects
None yet
2 participants