Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow codecov to create comment #7443

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Allow codecov to create comment #7443

merged 2 commits into from
Apr 4, 2024

Conversation

youngbupark
Copy link

@youngbupark youngbupark commented Apr 4, 2024

Description

When I removed issues permission, codecov can still update the previous comment. but looks like it is always required for creating new comment.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Signed-off-by: Young Bu Park <[email protected]>
@youngbupark youngbupark temporarily deployed to functional-tests April 4, 2024 03:57 — with GitHub Actions Inactive
Copy link

github-actions bot commented Apr 4, 2024

Test Results

3 136 tests  ±0   3 129 ✅ +2   3m 28s ⏱️ -3s
  261 suites ±0       7 💤 ±0 
    1 files   ±0       0 ❌  - 2 

Results for commit bba2b34. ± Comparison against base commit 6b0d59a.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.81%. Comparing base (bef1134) to head (bba2b34).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7443   +/-   ##
=======================================
  Coverage   63.81%   63.81%           
=======================================
  Files         416      416           
  Lines       23440    23440           
=======================================
  Hits        14958    14958           
  Misses       7223     7223           
  Partials     1259     1259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@youngbupark youngbupark changed the title [WIP] Set issues to write Allow codecov to create comment Apr 4, 2024
@youngbupark youngbupark marked this pull request as ready for review April 4, 2024 04:10
@youngbupark youngbupark requested review from a team as code owners April 4, 2024 04:10
@radius-functional-tests
Copy link

radius-functional-tests bot commented Apr 4, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 1d593b5
Unique ID funcc4550588bf
Image tag pr-funcc4550588bf
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc4550588bf
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc4550588bf
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc4550588bf
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc4550588bf
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting cli functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

@youngbupark youngbupark temporarily deployed to functional-tests April 4, 2024 04:45 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Apr 4, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref bba2b34
Unique ID funca08dcb6d6b
Image tag pr-funca08dcb6d6b
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca08dcb6d6b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca08dcb6d6b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funca08dcb6d6b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca08dcb6d6b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

@youngbupark youngbupark merged commit ea33bec into main Apr 4, 2024
20 checks passed
@youngbupark youngbupark deleted the youngp/enable-perm branch April 4, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants