Remove httpRoute type from Radius #7342

rynowak · 2024-03-15T21:03:29Z

Description

This change removes the httpRoute type. We've already removed this from documentation and samples and so this is the final removal.

Feels good 👍

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #6099

radius-functional-tests · 2024-03-18T16:34:21Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`cc87532`
Unique ID	150f4c534e
Image tag	pr-150f4c534e

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-150f4c534e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-150f4c534e
controller test image location: ghcr.io/radius-project/dev/controller:pr-150f4c534e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-150f4c534e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting cli functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
❌ shared functional test failed. Please check the logs for more details
❌ datastoresrp functional test cancelled. Please check the logs for more details

youngbupark · 2024-03-18T21:20:49Z

looks like port is not populated correctly.

"message": "failed to obtain environment variables and secret data: failed to parse source URL: address http-back-ctnr-simple1: missing port in address"

2024/03/18 16:47:10 Start streaming Kubernetes logs - Pod ctnr-sidecar-795b8fc884-gg8bx is in state: Failed
    cli.go:418: [rad] Building /home/runner/work/radius/radius/test/functional/shared/resources/testdata/corerp-resources-application-graph.bicep...
    cli.go:418: [rad] Deploying template '/home/runner/work/radius/radius/test/functional/shared/resources/testdata/corerp-resources-application-graph.bicep' into environment 'kind-radius' from workspace 'kind-radius'...
    cli.go:418: [rad] 
    cli.go:418: [rad] Deployment In Progress...
    cli.go:418: [rad] 
    cli.go:418: [rad] Error: {
    cli.go:418: [rad]   "code": "DeploymentFailed",
    cli.go:418: [rad]   "message": "At least one resource deployment operation failed. Please see the details for the specific operation that failed.",
    cli.go:418: [rad]   "target": "/planes/radius/local/resourceGroups/kind-radius/providers/Microsoft.Resources/deployments/rad-deploy-fba08a7b-9771-4895-af7f-2453ca3008f8",
    cli.go:418: [rad]   "details": [
    cli.go:418: [rad]     {
    cli.go:418: [rad]       "code": "OK",
    cli.go:418: [rad]       "message": "",
    cli.go:418: [rad]       "target": "/planes/radius/local/resourceGroups/kind-radius/providers/Applications.Core/applications/corerp-application-simple1"
    cli.go:418: [rad]     },
    cli.go:418: [rad]     {
    cli.go:418: [rad]       "code": "OK",
    cli.go:418: [rad]       "message": "",
    cli.go:418: [rad]       "target": "/planes/radius/local/resourceGroups/kind-radius/providers/Applications.Core/containers/http-back-ctnr-simple1"
    cli.go:418: [rad]     },
    cli.go:418: [rad]     {
    cli.go:418: [rad]       "code": "ResourceDeploymentFailure",
    cli.go:418: [rad]       "message": "Failed",
    cli.go:418: [rad]       "target": "/planes/radius/local/resourceGroups/kind-radius/providers/Applications.Core/containers/http-front-ctnr-simple1",
    cli.go:418: [rad]       "details": [
    cli.go:418: [rad]         {
    cli.go:418: [rad]           "code": "Internal",
    cli.go:418: [rad]           "message": "failed to obtain environment variables and secret data: failed to parse source URL: address http-back-ctnr-simple1: missing port in address"
    cli.go:418: [rad]         }
    cli.go:418: [rad]       ]
    cli.go:418: [rad]     }
    cli.go:418: [rad]   ]
    cli.go:418: [rad] }
    cli.go:418: [rad] 
    cli.go:418: [rad] TraceId:  633afd4fef6368507accf9e43e03f5da
    cli.go:418: [rad] 
    cli.go:418: [rad] 
    deployexecutor.go:[83](https://github.com/radius-project/radius/actions/runs/8330234023/job/22794667394#step:26:84): 
        	Error Trace:	/home/runner/work/radius/radius/test/step/deployexecutor.go:83
        	            				/home/runner/work/radius/radius/test/functional/shared/rptest.go:313
        	Error:      	Received unexpected error:
        	            	code DeploymentFailed: err At least one resource deployment operation failed. Please see the details for the specific operation that failed.
        	Test:       	Test_ApplicationGraph/deploy_testdata/corerp-resources-application-graph.bicep
make: *** [build/test.mk:78: test-functional-shared] Error 1
        	Messages:   	failed to deploy deploy testdata/corerp-resources-application-graph.bicep
    --- FAIL: Test_ApplicationGraph/deploy_testdata/corerp-resources-application-graph.bicep (18.41s)

nithyatsu · 2024-03-18T21:33:17Z

missing port in address

I remember there used to be logic to set port to 80 if scheme is http. Taking a look.

pkg/corerp/api/v20231001preview/volume_conversion_test.go

pkg/corerp/backend/deployment/deploymentprocessor_test.go

nithyatsu · 2024-03-18T21:57:01Z

Looks like we only have containerPort specified in the test bicep, in which case the service port == container port. So we have to have to specify :3000 as part of source url or add a port attribute to the service providing container.

 if port.Port == 0 {
			port.Port = port.ContainerPort
			properties.Container.Ports[portName] = port
		}

rynowak · 2024-03-22T20:21:01Z

Looks like we only have containerPort specified in the test bicep, in which case the service port == container port. So we have to have to specify :3000 as part of source url or add a port attribute to the service providing container.
 if port.Port == 0 {
			port.Port = port.ContainerPort
			properties.Container.Ports[portName] = port
		}

Thanks for helping investigate 👍 I'll address then when I get back from 🇫🇷

codecov · 2024-04-13T21:58:05Z

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 63.60%. Comparing base (4c23622) to head (f2f080a).

Files	Patch %	Lines
pkg/kubernetes/object.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7342      +/-   ##
==========================================
- Coverage   63.82%   63.60%   -0.22%     
==========================================
  Files         417      414       -3     
  Lines       23501    23289     -212     
==========================================
- Hits        14999    14813     -186     
+ Misses       7230     7217      -13     
+ Partials     1272     1259      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-04-13T22:05:22Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`138d084`
Unique ID	func5af01f1ff9
Image tag	pr-func5af01f1ff9

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func5af01f1ff9
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func5af01f1ff9
controller test image location: ghcr.io/radius-project/dev/controller:pr-func5af01f1ff9
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func5af01f1ff9
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded

Fixes: radius-project#6099 This change removes the httpRoute type. We've already removed this from documentation and samples and so this is the final removal. Feels good 👍 Signed-off-by: Ryan Nowak <[email protected]>

radius-functional-tests · 2024-04-14T18:44:57Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`f2f080a`
Unique ID	func3ba06bf777
Image tag	pr-func3ba06bf777

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3ba06bf777
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3ba06bf777
controller test image location: ghcr.io/radius-project/dev/controller:pr-func3ba06bf777
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3ba06bf777
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

rynowak · 2024-04-14T19:06:00Z

@nithyatsu @ytimocin - can you rereview?

typespec/Applications.Core/examples/2023-10-01-preview/Gateways_Update.json

typespec/Applications.Core/containers.tsp

test/functional-portable/corerp/noncloud/resources/application_test.go

nithyatsu · 2024-04-15T15:29:31Z

looks great to me.

rynowak requested review from a team as code owners March 15, 2024 21:03

nithyatsu approved these changes Mar 18, 2024

View reviewed changes

kachawla previously approved these changes Mar 18, 2024

View reviewed changes

rynowak temporarily deployed to functional-tests March 18, 2024 16:33 — with GitHub Actions Inactive

ytimocin reviewed Mar 18, 2024

View reviewed changes

pkg/corerp/api/v20231001preview/volume_conversion_test.go Show resolved Hide resolved

pkg/corerp/backend/deployment/deploymentprocessor_test.go Show resolved Hide resolved

rynowak dismissed kachawla’s stale review via 138d084 April 13, 2024 21:48

rynowak force-pushed the remote-http-route branch from cc87532 to 138d084 Compare April 13, 2024 21:48

rynowak temporarily deployed to functional-tests April 13, 2024 22:04 — with GitHub Actions Inactive

rynowak force-pushed the remote-http-route branch from 138d084 to 2a6c9e6 Compare April 14, 2024 18:41

Remove httpRoute type from Radius

f2f080a

Fixes: radius-project#6099 This change removes the httpRoute type. We've already removed this from documentation and samples and so this is the final removal. Feels good 👍 Signed-off-by: Ryan Nowak <[email protected]>

rynowak force-pushed the remote-http-route branch from 2a6c9e6 to f2f080a Compare April 14, 2024 18:43

rynowak temporarily deployed to functional-tests April 14, 2024 18:44 — with GitHub Actions Inactive

ytimocin reviewed Apr 14, 2024

View reviewed changes

typespec/Applications.Core/examples/2023-10-01-preview/Gateways_Update.json Show resolved Hide resolved

ytimocin reviewed Apr 14, 2024

View reviewed changes

typespec/Applications.Core/containers.tsp Show resolved Hide resolved

ytimocin reviewed Apr 14, 2024

View reviewed changes

test/functional-portable/corerp/noncloud/resources/application_test.go Show resolved Hide resolved

ytimocin approved these changes Apr 15, 2024

View reviewed changes

rynowak merged commit c756ab2 into radius-project:main Apr 15, 2024
17 checks passed

rynowak deleted the remote-http-route branch April 15, 2024 16:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove httpRoute type from Radius #7342

Remove httpRoute type from Radius #7342

rynowak commented Mar 15, 2024

radius-functional-tests bot commented Mar 18, 2024 •

edited

Loading

youngbupark commented Mar 18, 2024

nithyatsu commented Mar 18, 2024

nithyatsu commented Mar 18, 2024 •

edited

Loading

rynowak commented Mar 22, 2024

codecov bot commented Apr 13, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 13, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 14, 2024 •

edited

Loading

rynowak commented Apr 14, 2024

nithyatsu commented Apr 15, 2024

Remove httpRoute type from Radius #7342

Remove httpRoute type from Radius #7342

Conversation

rynowak commented Mar 15, 2024

Description

Type of change

radius-functional-tests bot commented Mar 18, 2024 • edited Loading

Radius functional test overview

Test Status

youngbupark commented Mar 18, 2024

nithyatsu commented Mar 18, 2024

nithyatsu commented Mar 18, 2024 • edited Loading

rynowak commented Mar 22, 2024

codecov bot commented Apr 13, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Apr 13, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Apr 14, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak commented Apr 14, 2024

nithyatsu commented Apr 15, 2024

radius-functional-tests bot commented Mar 18, 2024 •

edited

Loading

nithyatsu commented Mar 18, 2024 •

edited

Loading

codecov bot commented Apr 13, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 13, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 14, 2024 •

edited

Loading