Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate alternative options for linkType in environment recipe schema #6383

Closed
kachawla opened this issue Oct 13, 2022 · 3 comments
Closed

Comments

@kachawla
Copy link
Contributor

kachawla commented Oct 13, 2022

Capturing demo feedback from sprint 2. Suggestion was that if we can find an approach that will eliminate the need for the operator to specific linkType in the environment recipe details. One of the options that came up during the discussion was using metadata with the file.

import radius as radius

resource env 'Applications.Core/environments@2022-03-15-privatepreview' = {
  name: 'recipe-test-env'
  location: 'global'
  properties: {
    compute: {
      kind: 'kubernetes'
      resourceId: 'self'
      namespace: 'demo'
    }
    providers: {
      azure: {
        scope: '/subcriptions/66d1209e-1382-45d3-99bb-650e6bf63fc0/resourceGroup/test-rg'
      }
    }
    recipes: {
      mongo: {
          linkType: 'Applications.Link/mongoDatabases' 
          templatePath: 'radiusdev.azurecr.io/recipes/mongodatabases/azure:1.0' 
      }
    }
  }
}

AB#4416

AB#10030

@rynowak
Copy link
Contributor

rynowak commented Oct 17, 2022

For an example of metadata, the Bicep syntax for this looks like:

@metadata({ 'radius.connectorType': 'Applications.Connector/mongoDatabases'})

The keys and values are arbitrary, and metadata can be attached to basically anything in a Bicep file (eg: resources, parameters), including the file as a whole.

@rynowak
Copy link
Contributor

rynowak commented Oct 17, 2022

I think another factor here is that we want to expose the connector type via the API. Operations like listing recipes in the CLI won't be very intuitive if we can't display the most important information.

Right now we require the user to specify the connector type, so its automatically included in the API. Any changes we make to the design need to account for us populating the same information.

@AaronCrawfis AaronCrawfis changed the title Investigate alternative options for connectorType in environment recipe schema Investigate alternative options for linkType in environment recipe schema Feb 7, 2023
@willtsai willtsai transferred this issue from radius-project/radius Sep 19, 2023
@willtsai willtsai transferred this issue from another repository Sep 27, 2023
@kachawla
Copy link
Contributor Author

kachawla commented Nov 3, 2023

We have changed the schema since this was created, resource type is now a critical part of env recipe schema so this proposal is not applicable anymore. Closing.

@kachawla kachawla closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants