Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rad should validate that the AWS region specified (in the flag or interactive) is a valid region #6373

Closed
1 of 4 tasks
asilverman opened this issue Sep 22, 2022 · 3 comments
Closed
1 of 4 tasks
Labels
good first issue Good for newcomers

Comments

@asilverman
Copy link
Contributor

asilverman commented Sep 22, 2022

Overview of feature request

Since rad doesn't do this at the moment, if the user makes a mistake they will need to reinstall the radius control plane which is not a great user experience. Preferably instead of statically whitelisting the values we should fetch them from AWS API (as new regions can and will be added over time)

Use the equivalent REST API to get the following (reference https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeRegions.html)

aws ec2 describe-regions --all-regions --output json | jq ".Regions[].RegionName"
"af-south-1"
"eu-north-1"
"ap-south-1"
"eu-west-3"
"eu-west-2"
"eu-south-1"
"eu-west-1"
"ap-northeast-3"
"ap-northeast-2"
"me-south-1"
"ap-northeast-1"
"me-central-1"
"sa-east-1"
"ca-central-1"
"ap-east-1"
"ap-southeast-1"
"ap-southeast-2"
"ap-southeast-3"
"eu-central-1"
"us-east-1"
"us-east-2"
"us-west-1"
"us-west-2"

Definition of done:

AB#10389

@asilverman asilverman added the good first issue Good for newcomers label Sep 22, 2022
@Reshrahim
Copy link
Contributor

Reshrahim commented Sep 26, 2022

Need to explore if the region is a needed configuration for an AWS provider in rad cli. Can this part of the bicep?. Exploration tracked in #6376

@asilverman asilverman assigned asilverman and unassigned asilverman Sep 28, 2022
@willtsai
Copy link
Contributor

Let's fix this issue in the CLI first for public-release and follow with the Bicep flavor of the implementation.

@willtsai willtsai transferred this issue from radius-project/radius Sep 19, 2023
@willtsai willtsai transferred this issue from another repository Sep 27, 2023
@Reshrahim
Copy link
Contributor

This is fixed by listing the available AWS regions and prompting the user to pick one from the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants