Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contour deployment should allow for additional customization #6369

Open
infbase opened this issue Aug 19, 2022 · 1 comment
Open

Contour deployment should allow for additional customization #6369

infbase opened this issue Aug 19, 2022 · 1 comment
Labels
triaged This issue has been reviewed and triaged

Comments

@infbase
Copy link

infbase commented Aug 19, 2022

Overview of feature request
Contour deployment should allow for additional customization so that it works in clusters with additional constraints or existing configurations.

Additional context
Examples of additional configurations that must be supported (as helm values):

If external load balancers are blocked in AKS (via Azure Policy or Gatekeeper for instance) the load balancer must be annotated to use the internal LB:

envoy:
  service:
    annotations:
        "service.beta.kubernetes.io/azure-load-balancer-internal": "true"

Not being able to set this results in rad env init kubernetes failing in these clusters.

If other ingress controllers exist in the cluster, Contour should not be automatically set to default as that may have an impact on existing services:

contour:
  ingressClass:
    default: false

AB#6986

AB#9690

@willtsai willtsai transferred this issue from radius-project/radius Sep 19, 2023
@willtsai willtsai transferred this issue from another repository Sep 27, 2023
@nicolejms nicolejms added the triaged This issue has been reviewed and triaged label Oct 16, 2023
@infbase
Copy link
Author

infbase commented Aug 2, 2024

Current additional annotations needed on the LoadBalancer service, in our case:

    service.beta.kubernetes.io/azure-load-balancer-health-probe-request-path: /healthz
    service.beta.kubernetes.io/azure-load-balancer-internal: "true"
    service.beta.kubernetes.io/azure-load-balancer-internal-subnet: xxx  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged This issue has been reviewed and triaged
Projects
None yet
Development

No branches or pull requests

3 participants