From e6c8911716a5a03c5d38f62bb05648146a189d00 Mon Sep 17 00:00:00 2001 From: Shruthi Kumar Date: Tue, 5 Nov 2024 15:03:15 -0800 Subject: [PATCH] Update publish bicep step to run on environment (#8026) # Description This updates the build.yaml workflow to run on a Github environment during the publish bicep step. We currently have credentials set up for ref paths/branches but this requires a lot of credentials to be added for each pull/push case (i.e. we need a credential for PRs, pushes to main, release branches/tags, etc). Switching to an environment streamlines these credentials into one environment-based credential. See here for more details on the Github Actions setup: https://learn.microsoft.com/en-us/azure/app-service/deploy-github-actions?tabs=openid%2Caspnetcore#1-generate-deployment-credentials ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). Fixes: #issue_number ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - [ ] An overview of proposed schema changes is included in a linked GitHub issue. - [ ] A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] If applicable, design document has been reviewed and approved by Radius maintainers/approvers. - [ ] A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. --------- Signed-off-by: sk593 --- .github/workflows/build.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index a52b9747f5..0d54e178aa 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -265,6 +265,7 @@ jobs: build-and-push-bicep-types: name: Publish Radius bicep types to ACR runs-on: ubuntu-latest + environment: publish-bicep steps: - name: Check out code uses: actions/checkout@v4