From 2176ab878c3459ac41fdbc464993fe6cec685bcc Mon Sep 17 00:00:00 2001
From: Will Smith <willdavsmith@gmail.com>
Date: Thu, 28 Sep 2023 14:05:19 +0100
Subject: [PATCH] Add `--runtime-version` to functional test Dapr install
 (#6278)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Description

This might help with the increase in functional test failures we've been
seeing.

* Adding --runtime-version to functional test dapr install

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #6213

## Auto-generated summary

<!--
GitHub Copilot for docs will auto-generate a summary of the PR
-->

<!--
copilot:all
-->
### <samp>🤖 Generated by Copilot at 5eb2160</samp>

### Summary
:repeat::zap::bug:

<!--
1. :repeat: This emoji conveys the idea of retrying or repeating an
action until it succeeds, which is what the retry loop does for the
`dapr init` command. It also suggests a sense of persistence and
resilience, which are desirable qualities for a functional test
workflow.
2. :zap: This emoji conveys the idea of speed, power, or energy, which
are relevant for the dapr project, as it aims to provide a fast and easy
way to build distributed applications. It also suggests a sense of
improvement or enhancement, which is what the change does for the
workflow by making it more reliable and robust.
3. :bug: This emoji conveys the idea of fixing or preventing bugs,
errors, or issues, which is the main motivation for the change, as it
addresses the possibility of transient errors during the installation
process. It also suggests a sense of testing or debugging, which are
important aspects of the functional test suite.
-->
Retry `dapr init` in functional test workflow. This improves the
reliability of the test suite for the radius project, which depends on
dapr.

> _`dapr init` fails_
> _retry loop adds resilience_
> _autumn tests go on_

### Walkthrough
* Add a retry loop for `dapr init` command to handle transient errors
([link](https://github.com/radius-project/radius/pull/6278/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL420-R429))
---
 .github/workflows/functional-test.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/functional-test.yaml b/.github/workflows/functional-test.yaml
index b4bcfe42a1..6b1c49e01f 100644
--- a/.github/workflows/functional-test.yaml
+++ b/.github/workflows/functional-test.yaml
@@ -418,7 +418,7 @@ jobs:
       - name: Install dapr into cluster
         run: |
           wget -q https://raw.githubusercontent.com/dapr/cli/master/install/install.sh -O - | /bin/bash -s ${{ env.DAPR_VER }}
-          dapr init -k --wait --timeout 600
+          dapr init -k --wait --timeout 600 --runtime-version ${{ env.DAPR_VER }}
       - name: Install Azure Keyvault CSI driver chart
         run: |
           helm repo add csi-secrets-store-provider-azure https://azure.github.io/secrets-store-csi-driver-provider-azure/charts