From c76ce57f056e2ce6c00088c745446aca1c52660d Mon Sep 17 00:00:00 2001 From: jasonviviano <83607984+jasonviviano@users.noreply.github.com> Date: Mon, 6 Nov 2023 17:18:03 +0000 Subject: [PATCH 1/7] Adding Feedback mechanism that Dapr docs use Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> --- docs/config.toml | 5 +++ docs/layouts/partials/feedback.html | 62 +++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+) create mode 100644 docs/layouts/partials/feedback.html diff --git a/docs/config.toml b/docs/config.toml index ad8051c2e..13295907b 100644 --- a/docs/config.toml +++ b/docs/config.toml @@ -105,3 +105,8 @@ sidebar_menu_foldable = true sidebar_menu_truncate = 500 ul_show = 1 navbar_logo = true + +[params.ui.feedback] +enable = true +yes = 'Glad to hear it! Please tell us how we can improve.' +no = 'Sorry to hear that. Please tell us how we can improve.' diff --git a/docs/layouts/partials/feedback.html b/docs/layouts/partials/feedback.html new file mode 100644 index 000000000..27b991452 --- /dev/null +++ b/docs/layouts/partials/feedback.html @@ -0,0 +1,62 @@ + +
+

Feedback

+

Was this page helpful?

+ + +

+ {{ .yes | safeHTML }} +

+

+ {{ .no | safeHTML }} +

+
+ \ No newline at end of file From d06a99357d263d9417d180c36364dbf0cef65ad9 Mon Sep 17 00:00:00 2001 From: jasonviviano <83607984+jasonviviano@users.noreply.github.com> Date: Mon, 6 Nov 2023 19:16:21 +0000 Subject: [PATCH 2/7] Removing the partial layout Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> --- docs/layouts/partials/feedback.html | 62 ----------------------------- 1 file changed, 62 deletions(-) delete mode 100644 docs/layouts/partials/feedback.html diff --git a/docs/layouts/partials/feedback.html b/docs/layouts/partials/feedback.html deleted file mode 100644 index 27b991452..000000000 --- a/docs/layouts/partials/feedback.html +++ /dev/null @@ -1,62 +0,0 @@ - -
-

Feedback

-

Was this page helpful?

- - -

- {{ .yes | safeHTML }} -

-

- {{ .no | safeHTML }} -

-
- \ No newline at end of file From 1052960f688a00c80b7cb1519d554f4c9316dff7 Mon Sep 17 00:00:00 2001 From: jasonviviano <83607984+jasonviviano@users.noreply.github.com> Date: Mon, 6 Nov 2023 13:04:01 -0800 Subject: [PATCH 3/7] Apply suggestions from code review Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> --- docs/config.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/config.toml b/docs/config.toml index 13295907b..2e7511618 100644 --- a/docs/config.toml +++ b/docs/config.toml @@ -108,5 +108,5 @@ navbar_logo = true [params.ui.feedback] enable = true -yes = 'Glad to hear it! Please tell us how we can improve.' -no = 'Sorry to hear that. Please tell us how we can improve.' +yes = 'Glad to hear it! Please tell us how we can improve.' +no = 'Sorry to hear that. Please tell us how we can improve.' From 1b6221b7ff2553587b9458ab79df1aa060571b10 Mon Sep 17 00:00:00 2001 From: jasonviviano <83607984+jasonviviano@users.noreply.github.com> Date: Mon, 6 Nov 2023 22:53:53 +0000 Subject: [PATCH 4/7] Added a call to action on feedback widget Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> --- docs/config.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/config.toml b/docs/config.toml index 2e7511618..3ecbc51f9 100644 --- a/docs/config.toml +++ b/docs/config.toml @@ -108,5 +108,5 @@ navbar_logo = true [params.ui.feedback] enable = true -yes = 'Glad to hear it! Please tell us how we can improve.' -no = 'Sorry to hear that. Please tell us how we can improve.' +yes = 'Glad to hear it! Please feel free to star our repo and join our Discord server to stay up to date with the project. If you would like to also contribute a suggestion visit and tell us how we can improve.' +no = 'Sorry to hear that. If you would like to also contribute a suggestion visit and tell us how we can improve. Please feel free to star our repo and join our Discord server to stay up to date with the project.' From 77023d3d5597b4058cdefdc85cd03e46ae76bc15 Mon Sep 17 00:00:00 2001 From: jasonviviano <83607984+jasonviviano@users.noreply.github.com> Date: Tue, 7 Nov 2023 09:08:14 -0800 Subject: [PATCH 5/7] Update docs/config.toml Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> --- docs/config.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/config.toml b/docs/config.toml index 3ecbc51f9..24d6ec54a 100644 --- a/docs/config.toml +++ b/docs/config.toml @@ -108,5 +108,5 @@ navbar_logo = true [params.ui.feedback] enable = true -yes = 'Glad to hear it! Please feel free to star our repo and join our Discord server to stay up to date with the project. If you would like to also contribute a suggestion visit and tell us how we can improve.' +yes = 'Glad to hear it! Please feel free to star our repo and join our Discord server to stay up to date with the project.' no = 'Sorry to hear that. If you would like to also contribute a suggestion visit and tell us how we can improve. Please feel free to star our repo and join our Discord server to stay up to date with the project.' From 86be345cc676151b43853cd3ff59e2e3e88268dd Mon Sep 17 00:00:00 2001 From: jasonviviano <83607984+jasonviviano@users.noreply.github.com> Date: Tue, 7 Nov 2023 09:12:00 -0800 Subject: [PATCH 6/7] Update docs/config.toml Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> --- docs/config.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/config.toml b/docs/config.toml index 24d6ec54a..3a76830db 100644 --- a/docs/config.toml +++ b/docs/config.toml @@ -109,4 +109,4 @@ navbar_logo = true [params.ui.feedback] enable = true yes = 'Glad to hear it! Please feel free to star our repo and join our Discord server to stay up to date with the project.' -no = 'Sorry to hear that. If you would like to also contribute a suggestion visit and tell us how we can improve. Please feel free to star our repo and join our Discord server to stay up to date with the project.' +no = 'Sorry to hear that. If you would like to also contribute a suggestion visit and tell us how we can improve.' From f08229a1a9401f63cc107daac5bff27bef3c2f60 Mon Sep 17 00:00:00 2001 From: jasonviviano <83607984+jasonviviano@users.noreply.github.com> Date: Tue, 7 Nov 2023 11:37:22 -0800 Subject: [PATCH 7/7] Update docs/config.toml Co-authored-by: Aaron Crawfis Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> --- docs/config.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/config.toml b/docs/config.toml index 3a76830db..c918b1bde 100644 --- a/docs/config.toml +++ b/docs/config.toml @@ -108,5 +108,5 @@ navbar_logo = true [params.ui.feedback] enable = true -yes = 'Glad to hear it! Please feel free to star our repo and join our Discord server to stay up to date with the project.' +yes = 'Glad to hear it! Please feel free to star our repo and join our Discord server to stay up to date with the project.' no = 'Sorry to hear that. If you would like to also contribute a suggestion visit and tell us how we can improve.'