Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to add commit sign-off to the PR created by the upmerge workflow #1233

Closed
ytimocin opened this issue Sep 13, 2024 · 3 comments
Closed

Need to add commit sign-off to the PR created by the upmerge workflow #1233

ytimocin opened this issue Sep 13, 2024 · 3 comments
Assignees
@nithyatsu
Labels
triaged

Comments

@ytimocin
Copy link
Contributor

ytimocin commented Sep 13, 2024 •
edited by azure-boards bot
Loading

Need to add commit sign-off to the PR created by the upmerge workflow

AB#13198
@lakshmimsft
Copy link
Contributor

@ytimocin pls add more context. Clarify impact to the release process.

@ytimocin
Copy link
Contributor Author

The PR that is created by this workflow has a commit that is not signed off. I think (but I am not sure) the bot that creates this PR needs a DCO permission. See an example here.

@ytimocin
Copy link
Contributor Author

There is no impact to the release process. You just need to manually set the DCO to pass.

@nithyatsu nithyatsu mentioned this issue Sep 23, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nithyatsu nithyatsu

Labels
triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ytimocin @nithyatsu @lakshmimsft