From ae97e68d734be736a4e6442b4a5945d22e613bfb Mon Sep 17 00:00:00 2001 From: jasonviviano <83607984+jasonviviano@users.noreply.github.com> Date: Tue, 13 Feb 2024 14:33:28 -0500 Subject: [PATCH 1/3] Update limitations page to warn users that naming a gateway with the same name as a container causes an error (#1039) * Adding a known limitation for gateway resources Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> * Update docs/content/reference/limitations.md Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> * Update docs/content/reference/limitations.md Co-authored-by: Aaron Crawfis Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> * Added the error string for gateway resources sharing names with other resources. Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> * Update docs/content/reference/limitations.md Co-authored-by: Aaron Crawfis Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> --------- Signed-off-by: jasonviviano <83607984+jasonviviano@users.noreply.github.com> Co-authored-by: Aaron Crawfis --- docs/content/reference/limitations.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/content/reference/limitations.md b/docs/content/reference/limitations.md index 4e882b6f8..6751b40e9 100644 --- a/docs/content/reference/limitations.md +++ b/docs/content/reference/limitations.md @@ -34,6 +34,16 @@ As a workaround do not use underscores in resource names. Additional validation See [app name constraints]({{< ref "resource-schema.md#common-values" >}}) for more information. +### Gateway resources and container resources cannot share names + +Deploying a Radius Application that contains a gateway resource and a container resource that share a name will result in an error being thrown during deployment. For example, when attempting to name a container and a gateway something like "foo", you'll get an error messaging similar to: + +``` +Error - Type: IncludeError, Status: True, Reason: RootIncludesRoot, Message: root httpproxy cannot include another root httpproxy +``` + +As a workaround make sure to use distinct names for both containers and gateways. + ## rad CLI ### Application and resource names are lower-cased after deployment From 6ccbd6ee02e244314af3904946a425cff76b28a4 Mon Sep 17 00:00:00 2001 From: Karishma Chawla Date: Wed, 14 Feb 2024 16:39:41 -0800 Subject: [PATCH 2/3] Add GH action to close stale PRs (#1043) Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com> Co-authored-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com> --- .github/workflows/close-stale-prs.yml | 27 +++++++++++++++++++++++++++ CONTRIBUTING.md | 4 ++++ 2 files changed, 31 insertions(+) create mode 100644 .github/workflows/close-stale-prs.yml diff --git a/.github/workflows/close-stale-prs.yml b/.github/workflows/close-stale-prs.yml new file mode 100644 index 000000000..2ac1cd25e --- /dev/null +++ b/.github/workflows/close-stale-prs.yml @@ -0,0 +1,27 @@ +# This workflow warns and then closes PRs that have had no activity for 90 days. +# +# For more information, see: +# https://github.com/actions/stale +name: Close stale pull requests + +on: + schedule: + - cron: '0 18 * * *' # Run the workflow every day at 6PM UTC (10AM PST). + +jobs: + stale: + + runs-on: ubuntu-latest + permissions: + pull-requests: write + + steps: + - uses: actions/stale@v5 + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} + stale-pr-message: 'This pull request has been automatically marked as stale because it has been inactive for 90 days. Remove stale label or comment or this PR will be closed in 7 days.' + stale-pr-label: 'stale' + days-before-pr-stale: 90 # 3 months + days-before-pr-close: 7 + days-before-issue-stale: -1 + days-before-issue-close: -1 \ No newline at end of file diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f57a8067e..5ce157999 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -21,3 +21,7 @@ $ git commit -s -m 'This is my commit message' ``` Visual Studio Code has a setting, `git.alwaysSignOff` to automatically add a Signed-off-by line to commit messages. Search for "sign-off" in VS Code settings to find it and enable it. + +## Inactive Pull Requests + +Pull requests that have been inactive for 90 days will be marked with a stale label. They will automatically be closed after a subsequent 7 days of inactivity. This timeframe may be adjusted in the future based on project needs. \ No newline at end of file From c75151d309ee16ed617cf17f9721260c90000468 Mon Sep 17 00:00:00 2001 From: Karishma Chawla Date: Wed, 14 Feb 2024 16:40:08 -0800 Subject: [PATCH 3/3] Fix contribution guide link (#1044) Signed-off-by: Karishma Chawla --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b364ce4b1..79bd4a352 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ The [rad CLI](https://github.com/radius-project/radius/tree/main/cmd/rad) refere ## 👨‍💻 Contributing -Visit the [docs contribution guide](https://radapp.io/contributing/contributing-docs/) to learn how to contribute to the docs. +Visit the [docs contribution guide](https://docs.radapp.io/community/contributing/docs/) to learn how to contribute to the docs. ### Local server @@ -41,4 +41,4 @@ Staging docs are generated for each PR, with the URL posted as a comment. Access ## Code of Conduct -Please refer to our [Radius Community Code of Conduct](https://github.com/radius-project/radius/blob/main/CODE_OF_CONDUCT.md) \ No newline at end of file +Please refer to our [Radius Community Code of Conduct](https://github.com/radius-project/radius/blob/main/CODE_OF_CONDUCT.md)