You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While the Server supports initializing the server with global OnSubscribe and OnUnsubscribe callbacks, this applies to all streams. Allowing customized behavior for these events on a per-stream basis provides greater flexibility.
Problem
The Server contains only an unexported getStream method, so the consumer of this library cannot set the OnSubscribe callback on the Stream directly. This seems like a sensible choice, especially since access to resources on the Server requires synchronization via a sync.Mutex.
However the programmer can still kind of get around this by doing doing the following:
stream:=server.CreateStream(stream) // only creates the stream if it doesn't already existstream.OnSubscribe=customSubscribeFunc// not atomic, since CreateStream uses a mutex
While this kind of works, it seems like this was not the intent of the API and seems unsafe to rely on.
Proposed Solution
Export a method on the Server instance that allows customizing the callback per stream, for example:
Goal
While the
Server
supports initializing the server with globalOnSubscribe
andOnUnsubscribe
callbacks, this applies to all streams. Allowing customized behavior for these events on a per-stream basis provides greater flexibility.Problem
The
Server
contains only an unexportedgetStream
method, so the consumer of this library cannot set theOnSubscribe
callback on theStream
directly. This seems like a sensible choice, especially since access to resources on theServer
requires synchronization via async.Mutex
.However the programmer can still kind of get around this by doing doing the following:
While this kind of works, it seems like this was not the intent of the API and seems unsafe to rely on.
Proposed Solution
Export a method on the
Server
instance that allows customizing the callback per stream, for example:Example use case:
The text was updated successfully, but these errors were encountered: