-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support new substrate-contracts-node structure and stabilize integration tests #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 70.47% 72.59% +2.12%
==========================================
Files 54 56 +2
Lines 9250 10700 +1450
Branches 9250 10700 +1450
==========================================
+ Hits 6519 7768 +1249
- Misses 1737 1844 +107
- Partials 994 1088 +94
|
al3mart
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for addressing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces various fixes:
1- The latest release of
substrate-contracts-node
https://github.com/paritytech/substrate-contracts-node/releases/tag/v0.42.0 introduced a new directory structure for binary extraction. This change causedpop-cli
to fail when attempting to use the latest version. The logic has been updated to support both the old structure and the new structure.2- The CI has been failing in the integration test
launch_paseo_and_system_parachain
due to issues with version compatibility. The test now explicitly sets the version of Paseo tov1.3.3
wherecoretime-paseo-local
was introduced.3- Updated CI to trigger on events like
opened
,synchronize
,reopened
, andready_for_review
, instead of only for PRs targetingmain
.4- The function
run_contracts_node
has been updated to allow specifying the port for running thesubstrate-contracts-node
. This improvement facilitates running unit tests in parallel without port conflicts