feat: production build #354
Conversation
| use super::*; | ||
| use cli::MockCli; | ||
| use strum::VariantArray; | ||
|
|
||
| fn add_production_profile(project: &Path) -> anyhow::Result<()> { |
There was a problem hiding this comment.
Happy to hear where I can place this function as it now exists in three places.
There was a problem hiding this comment.
I had the same question in the pop call contract. The solution was to have a public function in the crate pop_contracts under a testing module that can be then used by the pop-cli https://github.com/r0gue-io/pop-cli/pull/306/files#diff-1735e49d7426a2bb8a539485425778554b43ef1ca455b26bd8138b69c69b18aeR27
There was a problem hiding this comment.
If we see it can be used in contracts then Ale's suggestion is the best approach.
There was a problem hiding this comment.
It will be used for parachains and builds, not for smart contracts as far as I'm aware. However, I see no reason not to place it in common.
@AlexD10S your suggestion doesn't use any feature flag? This means it is added to the compilation time of the users which doesn't seem ideal. I suggest we come up with a feature name that we can start to use in the repository
There was a problem hiding this comment.
A random idea; we add it to the templates Cargo.toml files which makes it a public crate function in general. Adding it will make the pop cli users aware of this possibility and will improve their chain when they go live to production, through this we create awareness for builders, a win.
There was a problem hiding this comment.
Looking at what it is actually doing, https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-common/src/manifest.rs might be the best candidate. It arguably should be improved to use the functionality available via the Manifest object - e.g. reading the manifest, checking if the profile already exists and adding if not.
Note: if it is moved to a library crate it should not use anyhow: https://github.com/dtolnay/anyhow?tab=readme-ov-file#comparison-to-thiserror.
There was a problem hiding this comment.
That is a great suggestion, I will not add it to the templates as default, something we can consider in the future
Daanvdplas
requested review from
AlexD10S and
al3mart
and removed request for
AlexD10S
There was a problem hiding this comment.
The only change requested is based on Ale's feedback about keeping the --release flag as deprecated.
Here’s how you can handle it:
1- Update the help message for the flag: https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-cli/src/commands/test/contract.rs#L18
2- If the flag is used, display a warning to inform the user: https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-cli/src/commands/test/contract.rs#L50
3- You can set the Profile to release if the flag was specified.
|
I'll do the rebase here |
al3mart
force-pushed
the
daan/feat-production_build
branch
from
d5d5bc0 to
7e46a67
Compare
chore: feedback and rebase
| // All commands originating from root command are valid | ||
| BuildParachainCommand { | ||
| path: args.path, | ||
| package: args.package, | ||
| release: args.release, | ||
| profile: Some(profile), |
There was a problem hiding this comment.
The Option requirement should be removed when removing the deprecated parachain build and contract command.
Adds the build profile to pop cli