-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use module CLI in all commands and add unit test in pop-cli crate #315
Open
AlexD10S
wants to merge
16
commits into
main
Choose a base branch
from
alex/unit-test-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arachain and pallet
AlexD10S
commented
Sep 20, 2024
) -> Result<Config> { | ||
if !matches!(template, Parachain::Standard) && | ||
if Provider::Pop.provides(template) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix needed. Customization values are available for all Pop templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors all
pop-cli
commands to use theCLI module
introduce in this PR #216, enabling us to test the output messages produced by theCLI
.Additionally, tests have been added to ensure better coverage in the
pop-cli
crate. As a result, the test coverage ofpop-cli
has increased significantly, from 34% to 67% with overall project coverage now nearing our goal: 80%.Coverage still can be improved, particularly the final parts of the
install
,build
, andup
commands, which are difficult to mock for a unit test.Note: The
call
command does not include tests because they are being addressed in parallel in this PR #306 to avoid duplication of work.