Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: instantiate tanssi container chains #285

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented Aug 16, 2024

This change allow users to instantiate Tanssi compatible container chain templates with pop new parachain.

@al3mart al3mart requested a review from AlexD10S August 16, 2024 18:52
@al3mart al3mart changed the title feat: Tanssi container chains feat: instantiate Tanssi container chains Aug 26, 2024
@al3mart al3mart marked this pull request as ready for review August 26, 2024 16:26
@al3mart
Copy link
Contributor Author

al3mart commented Aug 26, 2024

This is now ready for review @AlexD10S

Instantiation should be sorted. Leaving everything related to deployment for a following PR where we can take care of sourcing, preparing the specs and other nits required to fit Tanssi use case.

@al3mart al3mart requested a review from evilrobot-01 August 27, 2024 09:41
@evilrobot-01
Copy link
Contributor

Great stuff, looking forward to trying it out.

Suggest we hold off merging until the deployment PR is ready. Perhaps it could be a PR based on this one so it's easier to test when ready.

Base automatically changed from alex/refactor-releases to main August 27, 2024 14:02
@evilrobot-01 evilrobot-01 changed the title feat: instantiate Tanssi container chains feat: instantiate tanssi container chains Sep 18, 2024
crates/pop-common/src/manifest.rs Outdated Show resolved Hide resolved
crates/pop-common/src/manifest.rs Outdated Show resolved Hide resolved
crates/pop-common/src/manifest.rs Show resolved Hide resolved
crates/pop-common/src/manifest.rs Outdated Show resolved Hide resolved
name = "collator-01"

[[parachains.collators]]
name = "collator-02"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to run this many collators in a dev environment? Think of a dev with limited resources on their machine. This might give a bad experience.

name = "charlie"
validator = true

[[relaychain.nodes]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to run this many collators in a dev environment? Think of a dev with limited resources on their machine. This might give a bad experience.

@@ -0,0 +1,43 @@
[workspace]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this to be honest, its putting pressure on us to maintain and track the changes to their Cargo.toml if that is the purpose.

Can we not just use their version from the cloned/downloaded source code and amend that to avoid this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we can depend solely on the source manifest to craft these. It will require some tweaks in the logic. But nothing impossible.

crates/pop-parachains/src/templates.rs Outdated Show resolved Hide resolved
crates/pop-parachains/src/templates.rs Outdated Show resolved Hide resolved
crates/pop-parachains/src/templates.rs Outdated Show resolved Hide resolved
@al3mart al3mart added the ready-for-high-level-review The PR needs a high level review label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-high-level-review The PR needs a high level review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants