-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: instantiate tanssi container chains #285
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Frank Bell <[email protected]>
* refactor: directories instead of folders * style: fmt * stable fmt
This is now ready for review @AlexD10S Instantiation should be sorted. Leaving everything related to deployment for a following PR where we can take care of sourcing, preparing the specs and other nits required to fit Tanssi use case. |
Great stuff, looking forward to trying it out. Suggest we hold off merging until the deployment PR is ready. Perhaps it could be a PR based on this one so it's easier to test when ready. |
…argo refactor: improve conatiner workspace instantiation
name = "collator-01" | ||
|
||
[[parachains.collators]] | ||
name = "collator-02" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to run this many collators in a dev environment? Think of a dev with limited resources on their machine. This might give a bad experience.
name = "charlie" | ||
validator = true | ||
|
||
[[relaychain.nodes]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to run this many collators in a dev environment? Think of a dev with limited resources on their machine. This might give a bad experience.
@@ -0,0 +1,43 @@ | |||
[workspace] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this to be honest, its putting pressure on us to maintain and track the changes to their Cargo.toml if that is the purpose.
Can we not just use their version from the cloned/downloaded source code and amend that to avoid this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, we can depend solely on the source manifest to craft these. It will require some tweaks in the logic. But nothing impossible.
This change allow users to instantiate Tanssi compatible container chain templates with
pop new parachain
.