use cli instead of friendly_type_of #2568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oooh, I also fixed this in #2556 |
|
Ok, sure! I will close the PR once CI passes, just to make sure the rest of things is okay? |
|
Yeah, I'll close this one and merge the other momentarily. |
|
Also can you send me an email at [email protected]? I have a question to ask you that's more appropriate over email 😄 |
|
Sent! |
|
@olivroy hmmm I didn't get it |
|
@hadley.. I tried again.. otherwise, PM'd you on Mastodon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve CI failures! friendly_type_of is the legacy name. And apparently wasn't tested before #2552, which is why I didn't catch its use at the time.
fix clash between my deletion of compat-firendly-type in #2566 + use of friendly function in #2552