From e33a9991ef381b27ed09a075925254b3f7620527 Mon Sep 17 00:00:00 2001
From: gurglemurgle5 <95941332+gurglemurgle5@users.noreply.github.com>
Date: Fri, 19 Jul 2024 01:37:59 -0500
Subject: [PATCH] CommonClient: Escape markup sent in chat messages (#3659)

* escape markup in uncolored text

* Fix comment to allign with style guide

Fixes the comment so it follows the style guide, along with making it
better explain the code.

* Make more concise
---
 kvui.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kvui.py b/kvui.py
index 500203a8818f..1409e2dc0d45 100644
--- a/kvui.py
+++ b/kvui.py
@@ -836,6 +836,10 @@ def _handle_color(self, node: JSONMessagePart):
         return self._handle_text(node)
 
     def _handle_text(self, node: JSONMessagePart):
+        # All other text goes through _handle_color, and we don't want to escape markup twice,
+        # or mess up text that already has intentional markup applied to it
+        if node.get("type", "text") == "text":
+            node["text"] = escape_markup(node["text"])
         for ref in node.get("refs", []):
             node["text"] = f"[ref={self.ref_count}|{ref}]{node['text']}[/ref]"
             self.ref_count += 1