Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self hosted gitlab #118

Open
matfiz opened this issue Jan 31, 2019 · 3 comments · May be fixed by #129
Open

Self hosted gitlab #118

matfiz opened this issue Jan 31, 2019 · 3 comments · May be fixed by #129

Comments

@matfiz
Copy link

matfiz commented Jan 31, 2019

I am more than happy to see the support for Gitlab authentication!

It would be useful to add an extra param host_name to allow for custom self-hosted Gitlab domain (instead of the default gitlab.com).
@magikstm
Copy link
Contributor

I'm pretty sure @smancke may be open to a PR adding this feature.

In the meantime, if you self-compile loginsrv and/or caddy + loginsrv, you could try adjusting these 3 lines and I believe it may work:
https://github.com/tarent/loginsrv/blob/master/oauth2/gitlab.go#L13
https://github.com/tarent/loginsrv/blob/master/oauth2/gitlab.go#L33
https://github.com/tarent/loginsrv/blob/master/oauth2/gitlab.go#L34

I don't use Gitlab, so can't test or confirm.

@matfiz
Copy link
Author

matfiz commented Jan 31, 2019 •
edited
Loading

Thanks a lor @magikstm for your input! This is exactly what I've done locally (caddy+loginsrv) and it works as a charm! I'm have very little experience with golang though and would prefer a real wizzard like @smancke to perform the customization.

@xadereq
Copy link

xadereq commented May 13, 2019

@smancke could you provide this feature soon? Since new version of caddy(1.0.0) its getting harder and harder to use own fork of loginsrv.
It shouldn't be that much time consuming...

@gartnera gartnera linked a pull request May 19, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gitlab: use /oauth/userinfo and respect GITLAB_URL gartnera/loginsrv
3 participants
@matfiz @xadereq @magikstm