-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test and implementation for TimeReversalPulseTemplate ProgramBuilder support #866
Conversation
Test Results 6 files 6 suites 7m 29s ⏱️ Results for commit d7d8b33. ♻️ This comment has been updated with latest results. |
@Nomos11 I needed this because the documentation wont properly build otherwise but for my purposes the LoopBuilder is enough which I will merge in the other branch. The LinspaceBuilder time reversal does not work yet. |
3faa534
to
8282354
Compare
in that regard some changes on recent hacky dev branches are at feat/linspace_measurements_reversed |
@Nomos11 Please merge if there arent any objections. We should do a joint effort to merge the "hacky" branch into master ASAP |
considering the code quality there i don't know if one should. the main changes would correspond to the list compiled in #828, which may rather be up for a re-implementation with better approaches |
#865