Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and implementation for TimeReversalPulseTemplate ProgramBuilder support #866

Merged
merged 8 commits into from
Jan 4, 2025

Conversation

terrorfisch
Copy link
Member

@terrorfisch terrorfisch commented Jul 1, 2024

Copy link

github-actions bot commented Jul 1, 2024

Test Results

    6 files      6 suites   7m 29s ⏱️
1 198 tests 1 137 ✅  61 💤 0 ❌
7 188 runs  6 822 ✅ 366 💤 0 ❌

Results for commit d7d8b33.

♻️ This comment has been updated with latest results.

@terrorfisch terrorfisch changed the title Add failing test for TimeReversalPulseTemplate Add test and implementation for TimeReversalPulseTemplate ProgramBuilder support Jul 1, 2024
@terrorfisch
Copy link
Member Author

@Nomos11 I needed this because the documentation wont properly build otherwise but for my purposes the LoopBuilder is enough which I will merge in the other branch. The LinspaceBuilder time reversal does not work yet.

@terrorfisch terrorfisch marked this pull request as ready for review January 3, 2025 10:20
@terrorfisch terrorfisch force-pushed the issues/865_time_reversal_program_builder branch from 3faa534 to 8282354 Compare January 3, 2025 13:35
@Nomos11
Copy link
Collaborator

Nomos11 commented Jan 3, 2025

in that regard some changes on recent hacky dev branches are at feat/linspace_measurements_reversed

@terrorfisch
Copy link
Member Author

@Nomos11 Please merge if there arent any objections.

We should do a joint effort to merge the "hacky" branch into master ASAP

@Nomos11
Copy link
Collaborator

Nomos11 commented Jan 4, 2025

We should do a joint effort to merge the "hacky" branch into master ASAP

considering the code quality there i don't know if one should. the main changes would correspond to the list compiled in #828, which may rather be up for a re-implementation with better approaches

@Nomos11 Nomos11 merged commit 21469b7 into master Jan 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants