-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atssimple dac support #849
base: master
Are you sure you want to change the base?
Add atssimple dac support #849
Conversation
Test Results 3 files 3 suites 3m 46s ⏱️ Results for commit b33b9e6. ♻️ This comment has been updated with latest results. |
Usage: Jupyter Notebook Example |
Optimally include the usage example in doc/source/examples |
Code looks good to me |
"import qupulse.hardware\n", | ||
"import qupulse.hardware.awgs\n", | ||
"import qupulse.hardware.awgs.zihdawg\n", | ||
"import qupulse._program\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this import required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, see 1fcf616
Note that input range is not yet used to scale results. This needs to be implemented before merge |
Shouldn't this be implemented in simpleats itself? |
Yes, just forgot to pass required args. |
Note that here I implemented non-blocking acquisition in atssimple directly. Before merge this should be used in qupulse instead of the ad-hoc implementation. |
done |
done |
ready to merge btw |
Resolves #848