Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atssimple dac support #849

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

maxbeer99
Copy link

@maxbeer99 maxbeer99 commented Jun 17, 2024

Resolves #848

  • add newspiece

Copy link

github-actions bot commented Jun 17, 2024

Test Results

    3 files      3 suites   3m 46s ⏱️
1 196 tests 1 135 ✅  61 💤 0 ❌
3 588 runs  3 405 ✅ 183 💤 0 ❌

Results for commit b33b9e6.

♻️ This comment has been updated with latest results.

@maxbeer99
Copy link
Author

maxbeer99 commented Jun 17, 2024

Usage: Jupyter Notebook Example

@terrorfisch
Copy link
Member

Optimally include the usage example in doc/source/examples

@terrorfisch
Copy link
Member

Code looks good to me

"import qupulse.hardware\n",
"import qupulse.hardware.awgs\n",
"import qupulse.hardware.awgs.zihdawg\n",
"import qupulse._program\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this import required?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, see 1fcf616

@maxbeer99
Copy link
Author

Note that input range is not yet used to scale results. This needs to be implemented before merge

@terrorfisch
Copy link
Member

Shouldn't this be implemented in simpleats itself?

@maxbeer99
Copy link
Author

Shouldn't this be implemented in simpleats itself?

Yes, just forgot to pass required args.

@maxbeer99
Copy link
Author

Note that here I implemented non-blocking acquisition in atssimple directly. Before merge this should be used in qupulse instead of the ad-hoc implementation.

@maxbeer99
Copy link
Author

Note that input range is not yet used to scale results. This needs to be implemented before merge

done

@maxbeer99
Copy link
Author

Note that here I implemented non-blocking acquisition in atssimple directly. Before merge this should be used in qupulse instead of the ad-hoc implementation.

done

@maxbeer99
Copy link
Author

ready to merge btw

@maxbeer99 maxbeer99 marked this pull request as ready for review August 1, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement dac interface for atssimple
2 participants