From d562a91eef3c5e5770af400725040da5ad48a639 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Thu, 11 Jul 2024 04:07:26 +0100 Subject: [PATCH] Build: Restore support comments for Android 4/iOS 7 from c40934f3d0 We're nearing QUnit 3.0 release, and given IE 11 support remains, there was ultimately no code removed for Android 4-6 and iOS 7-8. While I can't integrate these in CI these and won't proactively test them around releases, we can continue to allow others to support these and report issues if need be. --- src/core/stacktrace.js | 2 +- src/core/utilities.js | 2 +- src/globals.js | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/core/stacktrace.js b/src/core/stacktrace.js index 8ffa92a51..fb692d441 100644 --- a/src/core/stacktrace.js +++ b/src/core/stacktrace.js @@ -90,7 +90,7 @@ export function extractStacktrace (e, offset) { export function sourceFromStacktrace (offset) { let error = new Error(); - // Support: IE 11 + // Support: IE 11, iOS 7 // Not all browsers generate the `stack` property for `new Error()` // See also https://github.com/qunitjs/qunit/issues/636 if (!error.stack) { diff --git a/src/core/utilities.js b/src/core/utilities.js index 1547b2182..12da5bc8c 100644 --- a/src/core/utilities.js +++ b/src/core/utilities.js @@ -74,7 +74,7 @@ export function objectValuesSubset (obj, model) { return subset; } -// Support: IE 11 +// Support: IE 11, iOS 7-8 export function extend (a, b, undefOnly, allProperties) { for (const prop in b) { if (hasOwn.call(b, prop) || allProperties) { diff --git a/src/globals.js b/src/globals.js index fe38e48cd..c06617456 100644 --- a/src/globals.js +++ b/src/globals.js @@ -64,6 +64,9 @@ export const sessionStorage = (function () { }()); // Fallback for ES6 Map, `new Map(iterable)`, and ES7 Map#keys +// +// Support: Safari 7; Map is undefined +// Support: iOS 8; `new Map(iterable)` is not supported // Support: IE 11; Map#keys is undefined export const StringMap = typeof g.Map === 'function' && typeof g.Map.prototype.keys === 'function' &&