From cc26bb9be2eab957c0d8761ff450da239de876fe Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Mon, 3 Apr 2023 16:39:03 +0200 Subject: [PATCH] add node v19 support (#1130) Closes https://github.com/quirrel-dev/quirrel/issues/1129 --- .github/workflows/ci.yml | 15 ++++++++------- package.json | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c74786338..4c44f8850 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,7 +14,7 @@ jobs: strategy: matrix: - node-version: [14, 16, 18] + node-version: [14, 16, 18, 19] fail-fast: false services: @@ -38,13 +38,14 @@ jobs: - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - - if: ${{ matrix.node-version == 14 }} + - if: ${{ matrix.node-version == 18 }} uses: microsoft/playwright-github-action@v1 - run: npm i -g npm@7 + - run: npm explore npm/node_modules/@npmcli/run-script -g -- npm_config_global=false npm install node-gyp@latest - run: npm ci - run: npm run build - run: npm test -- --coverage - - if: ${{ matrix.node-version == 14 }} + - if: ${{ matrix.node-version == 18 }} name: Coveralls Quirrel uses: coverallsapp/github-action@master with: @@ -52,17 +53,17 @@ jobs: github-token: ${{ secrets.GITHUB_TOKEN }} path-to-lcov: coverage/lcov.info parallel: true - - if: ${{ matrix.node-version == 14 }} + - if: ${{ matrix.node-version == 18 }} run: npm ci working-directory: development-ui - - if: ${{ matrix.node-version == 14 }} + - if: ${{ matrix.node-version == 18 }} name: Install Playwright Browsers run: npx playwright install --with-deps working-directory: development-ui - - if: ${{ matrix.node-version == 14 }} + - if: ${{ matrix.node-version == 18 }} run: npm run test:ci working-directory: development-ui - - if: ${{ matrix.node-version == 14 }} + - if: ${{ matrix.node-version == 18 }} name: Coveralls Finished uses: coverallsapp/github-action@master with: diff --git a/package.json b/package.json index bf7d90a77..f165ce6ad 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "module": "dist/esm/src/index.js", "version": "1.13.3", "engines": { - "node": "14 || 15 || 16 || 17 || 18" + "node": "14 || 15 || 16 || 17 || 18 || 19" }, "bin": { "quirrel": "cli.js"