-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative data types for output? #21
Comments
This is not useful for tantivy so I won't implement it, but I accept pull request. The binary size is indeed a problem, but we can put it behind a compilation flag. |
I would like to see support for |
@jean343 same answer as above unfortunately... |
Thank you for the answer. While I think about it, we are only storing deltas, and most |
I will try to take a stab a this for the Bitpack1. The parquet format uses this format and accepts both |
Not very easy in stable rust: the support for const generics is limited and we need it to call simd instructions irrespectively of the type, which requires a constant generic. Alternative is via macros. Will keep digging. |
This crate is super useful, thanks for writing/maintaining it!
I don't know if this is feasible but it would be nice if this crate could output to different types beyond
u32
. I needed to output tou8
to save space and I ended up rewriting a lot stuff for my purposes (I am only decompressing and always have the same width so I could simplify things).Having done so, I think that it'd be possible to add another level of macro magic here and output to
u8
andu16
for when those types are needed. I'm not too familiar with programming rust macros though, it might create a huge binary if it wasn't done carefully.Just thought I'd put it out there as a potential enhancement, thanks again for the crate.
The text was updated successfully, but these errors were encountered: