Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black screen after navigating to a ViewController with QueueIt #40

Open
alexanderthoren opened this issue Dec 4, 2024 · 2 comments
Open

Comments

@alexanderthoren
Copy link

alexanderthoren commented Dec 4, 2024

I’ve found an issue in the library and we can't integrate it until this is solved. Tested it with versions 3.4.4, 3.4.0 and 3.0.0. I've checked only the client side implementation.

It happens sometimes that the screen goes full black and the user has to kill the app and open it again, so that’s a no go.

To check if it was related to our own implementation (or maybe our code was interfering with the library) or not I created a super simple project with 2 ViewControllers, and it happened there too.

Check out the video:

ScreenRecording_12-03-2024.16-34-38_1.MP4

Proper solution would be:

  1. Launch the queue when accessing the 2nd viewController for the first time.
  2. Check if the queue must be shown or not. If not, don't show the black screen.

This is the zip of the simple project that can reproduce the error.
queueitexample.zip

@bret-queueit
Copy link
Contributor

Hi @alexanderthoren,
From your code and video looks like you are sending the user to queue multiples times, which is not good. To ensure proper functionality, please make sure to call QueueItEngine.run only once. You will need to manage the state within the app, determining whether the user has already been through the queue or not.

@alexanderthoren
Copy link
Author

I've checked an it only runs once. The issue happens when you're checking within the framework if it should present or not the queue. A race condition happens as before presenting the webview it tries to close it.

I've opened a PR with the migration to swift and the issue fixed, ensuring it works as expected every single time. Check it out -> #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants