Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated @QuarkusTestResource to @WithTestResource #494

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jul 29, 2024

@jedla97 jedla97 force-pushed the remove-quarkusTestResource branch from 2643a48 to 9fc08b6 Compare July 29, 2024 09:27
@jedla97 jedla97 force-pushed the remove-quarkusTestResource branch from 9fc08b6 to 1c7763d Compare July 29, 2024 10:06
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restrictToAnnotatedClass = false ... what's the key to add this?

I noticed you updated the PR 2 times, so the test failures triggered that?

@jedla97
Copy link
Member Author

jedla97 commented Jul 30, 2024

Yes the update was triggered by the failures. I miss one failure with first run.

restrictToAnnotatedClass = false ... what's the key to add this?

This is added when the test are executed outside of that class. With old annotation the default value for restrictToAnnotatedClass was false, bt now with WithTestResource the default is true.

@rsvoboda rsvoboda merged commit fb7edf5 into quarkus-qe:main Jul 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants