Compile any QuantumWorld to qubits
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the large PR. The interesting part is just in |
dstrain115
reviewed
Jan 3, 2023
| self.add_object(new_obj) | ||
| self.ancilla_names.add(ancilla_name) | ||
| new_obj = self._add_ancilla(namespace=obj.name, value=result) | ||
| # Swap the input and ancilla qubits using a remapping dict. |
There was a problem hiding this comment.
Is there a test case that exercises this new force measurement code?
There was a problem hiding this comment.
Added a bunch more tests. During those tests, realized that SparseSimulator does not support qudits at all but we can support that via this compilation.
dstrain115
approved these changes
Jan 31, 2023
| @@ -110,22 +177,98 @@ def test_pop(simulator): | |||
| assert all(result[1] != popped for result in results) | |||
|
|
|||
|
|
|||
| # TODO: Consider moving to qudit_effects.py if this can be broadly useful. | |||
There was a problem hiding this comment.
Agreed. Can be a separate PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #79
For enabling hardware-based runs, added an option to
QuantumWorldthat replaces qudits by ancilla qubits and transforms any qudit-basedQuantumEffectand measurements to be qubit-based. Uses the utils added in #69 for the actual unitary transformations.Updated all the applicable tests under
unitary/alphaandunitary/examples/tictactoeto run in both regular mode and qubit-compiled mode.This is still not all-powerful because the underlying qudit-to-qubit transforms assumed that all qudits in the system have the same dimension. Will work on generalizing that further next.