Allow measure_entanglement to calculate entanglement for multiple qubits #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstrain115
reviewed
Sep 10, 2024
| @@ -20,7 +20,8 @@ | |||
| from unitary.alpha.sparse_vector_simulator import PostSelectOperation, SparseSimulator | |||
| from unitary.alpha.qudit_state_transform import qudit_to_qubit_unitary, num_bits | |||
| import numpy as np | |||
| import itertools | |||
| from itertools import combinations | |||
There was a problem hiding this comment.
Prefer import itertools then itertools.combinations below
"Use import statements for packages and modules only, not for individual types, classes, or functions."
https://google.github.io/styleguide/pyguide.html#22-imports
| entanglement[j][i] = entanglement[i][j] | ||
| names = list(self.object_name_dict.keys()) | ||
| data_frame = pd.DataFrame(entanglement, index=names, columns=names) | ||
| print(data_frame.round(1)) |
There was a problem hiding this comment.
Should we return the data_frame (or some other result) instead of printing it?
Printing it seems generally unhelpful if we are using this within a game.
| entropy = [0.0] * num_qubits | ||
| entropy_pair = np.zeros((num_qubits, num_qubits)) | ||
| entanglement = np.zeros((num_qubits, num_qubits)) | ||
| for i in range(num_qubits - 1): |
There was a problem hiding this comment.
I think this block is fairly tough to follow. I would add comments below or in the function's docstring to explain the implementation details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update quantum world to