From 7f1d41d0b1b35cd167a3218f6bf8452e197352bd Mon Sep 17 00:00:00 2001
From: Francesco Vertemati <francesco.vertemati@qognitive.io>
Date: Tue, 27 Aug 2024 15:56:48 -0400
Subject: [PATCH] add ecr login

---
 Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 5657dfa..ada72c7 100644
--- a/Makefile
+++ b/Makefile
@@ -1,3 +1,5 @@
+AWS_ACCOUNT_ID ?= 885886606610
+AWS_REGION ?= us-east-2
 
 .PHONY: build
 build:  schema-build
@@ -32,9 +34,9 @@ test-unit:
 	pytest -v --cov=qcog_python_client tests/unit
 
 test-integration:
-	aws ecr get-login-password --region ${AWS_REGION} | docker login --username AWS --password-stdin ${AWS_ACCOUNT_ID}.dkr.ecr.${AWS_REGION}.amazonaws.com && \
 	export PYTHONPATH=. && \
 	export AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} && \
 	export AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} && \
 	export AWS_SESSION_TOKEN=${AWS_SESSION_TOKEN} && \
+	aws ecr get-login-password --region ${AWS_REGION} | docker login --username AWS --password-stdin ${AWS_ACCOUNT_ID}.dkr.ecr.${AWS_REGION}.amazonaws.com && \
 	pytest -v --cov=qcog_python_client tests/integration