Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: display plugin ID to the plugin page with a copy button #343

Closed
Guts opened this issue Jan 11, 2024 · 3 comments
Closed
Assignees
Labels
🕔 Size 2 Give me 2 hours and I will have it for you

Comments

@Guts
Copy link
Contributor

Guts commented Jan 11, 2024

For now, the plugin ID is displayed into the repository XML file and the search results (between brackets)

image

but not on the plugin page:

image

It would be a good idea to display this identifier on the plugin page, under its name and in the details tab, along with a simple mechanism for copying it to the clipboard, either via a small button next to it, or on click with the appropriate tooltip to indicate it.

I've in mind the UI mechanism in Gitlab:

image

@Xpirix Xpirix self-assigned this Jan 16, 2024
@Xpirix Xpirix added the 🕔 Size 2 Give me 2 hours and I will have it for you label Jan 16, 2024
@Xpirix Xpirix moved this to This sprint in Lova Work Planning Jan 16, 2024
@Xpirix Xpirix moved this from This sprint to In Progress in Lova Work Planning Jan 16, 2024
@Xpirix Xpirix moved this from In Progress to Review in progress in Lova Work Planning Jan 16, 2024
@Xpirix
Copy link
Collaborator

Xpirix commented Jan 16, 2024

Dear @Guts

Please find at #344 the proposed PR for this issue.

Best regards,

@Guts
Copy link
Contributor Author

Guts commented Jan 16, 2024

Woa it was fast! 👏

Thanks @Xpirix for the quick implementation.

To complete my feature request, I forgot to mention the concrete use case that motivates this issue.

When an end-user is listing the plugins the profile.json used by QDT, it requires some hard operations and needs custom step-by-step guide like this one https://guts.github.io/qgis-deployment-cli/guides/howto_qgis_get_plugin_id.html

In a greater view, I suggest that we think next about repositories consistent ID. For now, I'm using the repository url in conjunction with plugin ID to get an unique URI accross different repositories where the same plug-in can be referenced.

@Guts
Copy link
Contributor Author

Guts commented Jan 16, 2024

FYI @sigeal and @florentfgrs

@Xpirix Xpirix moved this from Review in progress to Review approved in Lova Work Planning Feb 1, 2024
@Xpirix Xpirix closed this as completed Feb 8, 2024
@github-project-automation github-project-automation bot moved this from Review approved to Done in Lova Work Planning Feb 8, 2024
Guts added a commit to qgis-deployment/qgis-deployment-toolbelt-cli that referenced this issue Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 Size 2 Give me 2 hours and I will have it for you
Projects
Development

No branches or pull requests

2 participants