Merge pull request #464 from Xpirix/form_resubmission

Feedback resubmission fix
qgis · Nov 21, 2024 · 10598b8 · 10598b8
2 parents ea5dd31 + 4955a95
commit 10598b8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/dockerize/docker/REQUIREMENTS.txt b/dockerize/docker/REQUIREMENTS.txt
@@ -62,3 +62,4 @@ uwsgi~=2.0
 freezegun~=1.4
 
 sentry-sdk~=2.2
+setuptools~=74.1
diff --git a/qgis-app/plugins/tests/test_plugin_version_feedback.py b/qgis-app/plugins/tests/test_plugin_version_feedback.py
@@ -331,7 +331,7 @@ def test_post_create_single_task_feedback(self):
                 "feedback": "single line feedback"
             }
         )
-        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.status_code, 302)
         feedbacks = PluginVersionFeedback.objects.filter(
             version=self.version_2).all()
         self.assertEqual(len(feedbacks), 1)
@@ -345,7 +345,7 @@ def test_post_create_multiple_task_feedback(self):
                 "feedback": "- [ ] task one\n - [ ] task two"
             }
         )
-        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.status_code, 302)
         feedbacks = PluginVersionFeedback.objects.filter(
             version=self.version_2).all()
         self.assertEqual(len(feedbacks), 2)

diff --git a/qgis-app/plugins/views.py b/qgis-app/plugins/views.py
@@ -1434,6 +1434,10 @@ def version_feedback(request, package_name, version):
                     task=task
                 )
             version_feedback_notify(version, request.user)
+            return HttpResponseRedirect(
+                reverse('version_feedback', 
+                args=[package_name, version.version])
+            )
     form = VersionFeedbackForm()
     feedbacks = PluginVersionFeedback.objects.filter(version=version)
     return render(