Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/202212 desktop settings #987

Merged
merged 6 commits into from
Dec 5, 2022
Merged

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Dec 5, 2022

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@qdraw qdraw linked an issue Dec 5, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #987 (d164e3d) into master (43264a3) will decrease coverage by 0.18%.
The diff coverage is 13.33%.

❗ Current head d164e3d differs from pull request most recent head 673e290. Consider uploading reports for the commit 673e290 to get more accurate results

@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
- Coverage   91.77%   91.59%   -0.19%     
==========================================
  Files         481      482       +1     
  Lines       16934    16948      +14     
  Branches     2847     2848       +1     
==========================================
- Hits        15542    15523      -19     
- Misses        831      868      +37     
+ Partials      561      557       -4     
Flag Coverage Δ
all 91.59% <13.33%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
starsky/starsky/Controllers/CpuTestController.cs 0.00% <0.00%> (ø)
...arsky/starsky/clientapp/src/containers/archive.tsx 100.00% <ø> (ø)
...olecules/color-class-filter/color-class-filter.tsx 88.63% <100.00%> (+0.26%) ⬆️
...rsky.feature.geolookup/Services/GeoFileDownload.cs 10.52% <0.00%> (-50.00%) ⬇️
starsky/starskygeocli/Program.cs 90.47% <0.00%> (-9.53%) ⬇️
...arsky/starsky.feature.geolookup/Services/GeoCli.cs 87.14% <0.00%> (-4.29%) ⬇️
.../starsky.foundation.platform/Helpers/ArgsHelper.cs 99.69% <0.00%> (+0.61%) ⬆️
starsky/starskyimportercli/Program.cs 100.00% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qdraw qdraw linked an issue Dec 5, 2022 that may be closed by this pull request
@qdraw qdraw merged commit 9192d6f into master Dec 5, 2022
@qdraw qdraw deleted the feature/202212_desktop_settings branch December 5, 2022 18:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

23.5% 23.5% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI improvements Desktop App - update window does not work anymore (blank)
1 participant