-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing Phase
instead of Symmetry
#480
Comments
@hakonanes Seems simple enough and would be a nice addition |
I think this would be a convenient addition to |
That was my intention, yes,wherever it makes sense. |
I'm not sure of the best implementation. Should we allow passing a |
Would it be enough to improve the docstrings and examples with an example extracting the |
As @CSSFrancis pointed out in #478 (comment), it may sometimes be simpler to pass a
Phase
with a point group set, rather than extracting the correspondingSymmetry
, to functions like the sampling functions. Since aPhase
only has oneSymmetry
, this should not be a problem.I'm for this. What do other people think?
The text was updated successfully, but these errors were encountered: