Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a fork of symposion and replacing all old instance of render_to_response to render #21

Open
gbozee opened this issue Feb 17, 2018 · 6 comments

Comments

@gbozee
Copy link

gbozee commented Feb 17, 2018

Since we are currently pulling from the base symposion repo, we are stuck with their implementation which includes some old implementation for render_to_response. We would need to create a fork and fix all this issue and any issue that might arise.

@danidee10
Copy link

@gbozee I've created a fork here https://github.com/pyung/symposion that we can use.

@gbozee
Copy link
Author

gbozee commented Feb 18, 2018

Great @danidee10 hope u know that the central branch now is cfp and not develop when merging PRS?

@danidee10
Copy link

@gbozee Yes, I know.

@gbozee
Copy link
Author

gbozee commented Feb 18, 2018

Please also update the requirements link to point to this fork instead of the default. and submit a pr on this.

@danidee10
Copy link

@gbozeeI've done that. is there any need to create a development branch in the symposion repo and open PR's or We should just push changes to master directly?

@gbozee
Copy link
Author

gbozee commented Feb 20, 2018

no need. Let all the work be done directly on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants