Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure generator.py according to the utilities #8

Open
ashwini0529 opened this issue Oct 1, 2017 · 6 comments
Open

Restructure generator.py according to the utilities #8

ashwini0529 opened this issue Oct 1, 2017 · 6 comments

Comments

@ashwini0529
Copy link
Member

As of now, there are multiple functionalities implemented in a single file. Most of the generator functions are Faker oriented. Maybe a separate file handles such functions.

@theycallmemac
Copy link
Contributor

Just had a look at this. You want the functions using Faker to be separated from the few that don't?

@ashwini0529
Copy link
Member Author

Yeah basically the purpose of generator is to generate data. Now that maybe using Faker, built-in functions, or any other way. generator.py should be in such a way, that it should not contain much of a repeated code, or functions.

@theycallmemac
Copy link
Contributor

So rather than having separate files handling such functions as you've said above, this is just a refactoring issue?

@ashwini0529
Copy link
Member Author

Yeah kind of refactoring issue.

@ashwini0529
Copy link
Member Author

Hey @theycallmemac , can you please check a comment that I made on your PR?
That would be ready to merge then. 🎉

@theycallmemac
Copy link
Contributor

Isn't it merged already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants