Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch python3 #64

Closed
wants to merge 2 commits into from
Closed

Patch python3 #64

wants to merge 2 commits into from

Conversation

Vipul-Bajaj
Copy link

@Vipul-Bajaj Vipul-Bajaj commented Oct 8, 2019 •
edited
Loading

Migrated to python3. Resolves #63

@Vipul-Bajaj
Copy link
Author

Hi @shubhodeep9 ,
Does the code have some bug, as I see it has been pending review for many days?
Do let me know, if something is wrong.

shubhodeep9
shubhodeep9 requested changes Oct 14, 2019
View reviewed changes
Copy link
Member

@shubhodeep9 shubhodeep9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you covered all modules?

hackr/crypto.py Show resolved Hide resolved
Vipul-Bajaj
Vipul-Bajaj commented Oct 16, 2019
View reviewed changes
Copy link
Author

@Vipul-Bajaj Vipul-Bajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to change

@Vipul-Bajaj Vipul-Bajaj closed this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhodeep9 shubhodeep9 shubhodeep9 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ditch Python2
2 participants
@Vipul-Bajaj @shubhodeep9