Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete usage of Faker in generator.py #4

Open
ashwini0529 opened this issue Oct 1, 2017 · 6 comments
Open

Complete usage of Faker in generator.py #4

ashwini0529 opened this issue Oct 1, 2017 · 6 comments
Labels
enhancement hacktoberfest

Comments

@ashwini0529
Copy link
Member

Right now it generates name and addresses using Faker.
Faker could be utilised completely to add more functionalities.
@vaibhavsingh97
Copy link

I want to fix this issue 😄

@willBoyd8
Copy link
Contributor

How about some networking to get it going? #7.

It might be beneficial to restructure a little, as all of faker implemented in 1 file could be a bit of a mess...

@ashwini0529
Copy link
Member Author

It would be great. @willBoyd8 if you restructure all Faker implementations in one file and use it in generators. 😄

@ashwini0529 ashwini0529 mentioned this issue Oct 1, 2017
Merged
@willBoyd8
Copy link
Contributor

See if #13 is what you'd like... That also makes it easy for others ( @vaibhavsingh97 ) to add other functionality too. The month of hacktober is still young... ;)

@ashwini0529
Copy link
Member Author

Hey, @willBoyd8 can you please check a comment that I made on your PR?
That would be ready to merge then. 🎉

@willBoyd8
Copy link
Contributor

Yeah sorry. I'm a little slow on weekdays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashwini0529 @vaibhavsingh97 @willBoyd8