Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] TorchRL for Python 3.13t #2535

Open
patchmeifyoucan opened this issue Nov 4, 2024 · 2 comments
Open

[Feature Request] TorchRL for Python 3.13t #2535

patchmeifyoucan opened this issue Nov 4, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@patchmeifyoucan
Copy link

Hello, PyTorch recently added support for Python 3.13t, aka "no-gil" Python (pytorch/pytorch#130249).
Are there any plans to make TorchRL usable from this version? It would be nice if this could be supported soon, as the ability to run CPU code for interactions with the environment from multiple no-gil threads could lead to major performance improvements and higher GPU utilization.

@patchmeifyoucan patchmeifyoucan added the enhancement New feature or request label Nov 4, 2024
@vmoens
Copy link
Contributor

vmoens commented Nov 6, 2024

That's definitely on our radar!
Beyond multithreaded envs another big benefit would be reducing the cpu overheads across the lib (sampling in rbs, iterating over TensorDict etc).

Is there anything we should prioritise in your opinion?

@patchmeifyoucan
Copy link
Author

Thank you, good to know.

For me, simply general support would be sufficient to get a better GPU utilization, that's what I'm after. I mostly use torchrl's replay buffers but their performance is far from being a bottleneck in my application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants