Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedding accuracy check #98

Closed
wants to merge 1 commit into from
Closed

Conversation

FindHao
Copy link
Member

@FindHao FindHao commented Dec 5, 2024

Force different implementations to use same weight data to make sure the accuracy check fair.

Test Plan:

% python run.py --op embedding --num-inputs 1 --input-id 11 --precision fp32  --cudagraph --metrics accuracy
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:04<00:00,  4.24s/it]
         (B, T, D, V)    liger_embedding-accuracy    inductor_embedding-accuracy
---------------------  --------------------------  -----------------------------
(8, 2048, 4096, 8192)                           1                              1

@facebook-github-bot
Copy link
Contributor

@FindHao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@facebook-github-bot
Copy link
Contributor

@FindHao merged this pull request in de24cc4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants