Add backport of evaluate_forward_ref
#497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jelle Zijlstra <[email protected]>
AlexWaygood
changed the title
evalaute_forward_refevaluate_forward_ref
restructuring & comments
Co-authored-by: Jelle Zijlstra <[email protected]>
Daraan
commented
Oct 30, 2024
Comment on lines
3826
to
+3827
| SOURCE = 3 | ||
| STRING = 3 |
There was a problem hiding this comment.
I guess, SOURCE will be removed soon?
Daraan
commented
Oct 30, 2024
Comment on lines
+8369
to
+8370
| if _FORWARD_REF_HAS_CLASS | ||
| else Final # will not raise error in older versions |
There was a problem hiding this comment.
I am not sure if Final should throw errors in earlier versions that do not implement __forward_is_class__
Comment on lines
+8140
to
+8142
| # Assure that these are not in globals | ||
| assert X.__name__ not in globals() | ||
| assert Y.__name__ not in globals() |
There was a problem hiding this comment.
These asserts are important for test design; should I use self.assertNotIn instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports
evaluate_forward_reffrom JelleZijlstra's PR python/cpython#119891 / PEP 749.The most tricky part seems to be in recursive
ForwardRefs, at least in my tests they worked better in 3.9 and but not in 3.8 and 3.10. If someone has some nice examples how to break it I gladly add them.Limitation has been added to the docs.
Tests are also tested against cpython
mainpython/cpython@079875e39