Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license identifier in project metadata to text #451

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mschoettle
Copy link

I'd like to propose changing the license metadata to text with the license identifier "Python-2.0" reflecting the content of the LICENSE file.

License scanning tools such as the one GitLab uses rely on the license field returned by the PyPI API which returns license: null for this package (JSON).

Related to #62

Copy link

cpython-cla-bot bot commented Aug 23, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@srittau
Copy link
Collaborator

srittau commented Aug 29, 2024

Thanks, it makes sense to me to use a classifier here. The documentation for pyproject.toml says to use of the license classifiers from the classifiers list (minus the prefix). But I can't find "Python-2.0" on that list?

@mschoettle
Copy link
Author

Unfortunately, the classifiers are ambiguous (or not complete) for some licenses (BSD, Python, Apache). See also here: pypa/trove-classifiers#17. It seems that the classifiers are not taken into account for the license field that the PyPI API returns. With the license being specified as proposed by this PR the API returns the license field.

There is also now PEP 639 (provisional) which aims to improve this.

@srittau
Copy link
Collaborator

srittau commented Aug 30, 2024

I don't think we should use classifiers that contradict the official documentation. It's great to see that there's some progress to improve the license situation, but I'd prefer to wait until there's an officially accepted solution. But I'll defer the decision to @JelleZijlstra and @AlexWaygood here, as core developers and most active regarding typing_extensions.

@AlexWaygood AlexWaygood self-requested a review August 30, 2024 15:16
@JelleZijlstra
Copy link
Member

I am not very familiar with packaging arcana, but I'd prefer to avoid relying on any unspecified behavior, and instead use PEP 639 now that it's been provisionally accepted.

@srittau
Copy link
Collaborator

srittau commented Aug 30, 2024

I am not very familiar with packaging arcana, but I'd prefer to avoid relying on any unspecified behavior, and instead use PEP 639 now that it's been provisionally accepted.

That's the most sensible approach, but I don't think flit supports PEP 639 yet.

@mschoettle
Copy link
Author

Waiting for PEP 639 makes sense to me.

There is now a feature request for flit: pypa/flit#692

@mschoettle mschoettle marked this pull request as draft September 3, 2024 15:36
@AlexWaygood AlexWaygood removed their request for review September 23, 2024 18:26
@AlexWaygood
Copy link
Member

Has this been superseded by #507?

@mschoettle
Copy link
Author

Looks like it. Although it uses the old syntax, not the new one introduced by PEP 639 I think.

@cdce8p
Copy link
Contributor

cdce8p commented Nov 20, 2024

Looks like it. Although it uses the old syntax, not the new one introduced by PEP 639 I think.

flit_core doesn't yet support the new syntax and would raise a ConfigError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants