Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 683: Mark Final #3824

Merged
merged 4 commits into from
Jun 12, 2024
Merged

PEP 683: Mark Final #3824

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
547b86e
PEP 683: mark as Final
ncoghlan Jun 6, 2024
125dd48
canonical-doc markup != comment markup
ncoghlan Jun 6, 2024
662951d
Content-Type is redundant now
ncoghlan Jun 6, 2024
6989947
Farewell, Emacs config
ncoghlan Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions peps/pep-0683.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PEP: 683
Title: Immortal Objects, Using a Fixed Refcount
Author: Eric Snow <[email protected]>, Eddie Elizondo <[email protected]>
Discussions-To: https://discuss.python.org/t/18183
Status: Accepted
Status: Final
Type: Standards Track
Content-Type: text/x-rst
ncoghlan marked this conversation as resolved.
Show resolved Hide resolved
Created: 10-Feb-2022
Expand All @@ -13,20 +13,18 @@ Post-History: `16-Feb-2022 <https://mail.python.org/archives/list/python-dev@pyt
`12-Aug-2022 <https://discuss.python.org/t/18183>`__,
Resolution: https://discuss.python.org/t/18183/26

.. canonical-doc:: :term:`reference count`

PEP Acceptance Conditions
=========================

The PEP was accepted with conditions:

* we must apply the primary proposal
in `Solutions for Accidental De-Immortalization`_
(reset the immortal refcount in ``tp_dealloc()``)
* types without this may not be immortalized (in CPython's code)
* the PEP must be updated with final benchmark results once
the implementation is finalized
* we will have one last round of discussion about those results at that point

* the primary proposal in `Solutions for Accidental De-Immortalization`_
(reset the immortal refcount in ``tp_dealloc()``) was applied
* types without this were not immortalized (in CPython's code)
* the PEP was updated with final benchmark results once
the implementation is finalized (confirming the change is worthwhile)

Abstract
========
Expand Down