Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 544: Update Example #3783

Merged
merged 1 commit into from
May 17, 2024
Merged

PEP 544: Update Example #3783

merged 1 commit into from
May 17, 2024

Conversation

1chooo
Copy link
Contributor

@1chooo 1chooo commented May 15, 2024 •
edited by github-actions bot
Loading

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

Related issue: #3312

📚 Documentation preview 📚: https://pep-previews--3783.org.readthedocs.build/

@1chooo
Copy link
Contributor Author

1chooo commented May 15, 2024

@levkivskyi, @ambv Could you please review this pull request? If there are no issues, could you merge it and allow contributions to the python/peps?

ilevkivskyi
ilevkivskyi approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are stricter rules to change Accepted/Final PEPs, so will need to find a second person to merge this. The change itself LGTM.

@JelleZijlstra
Copy link
Member

This kind of change that doesn't change the contents is fine to merge.

@JelleZijlstra JelleZijlstra merged commit fca6000 into python:main May 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1chooo @JelleZijlstra @ilevkivskyi