Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-127146 Emscripten: Skip segfaults in test suite #127151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-127146 Emscripten: Skip segfaults in test suite #127151

wants to merge 1 commit into from
+57 −20

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Nov 22, 2024 •
edited by bedevere-app bot
Loading

After this, Emscripten makes it all the way through the test suite when I run it locally.

@bedevere-app bedevere-app bot mentioned this pull request Nov 22, 2024
Open
@hoodmane hoodmane force-pushed the fix-emscripten-test-segfaults branch 2 times, most recently from a281d38 to c11b73b Compare November 22, 2024 14:37
@rhettinger rhettinger removed their request for review November 22, 2024 20:16
mdboom
mdboom requested changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if this sounds overly pedantic, but isn't this "skipping tests that segfault" rather than "fixing tests that segfault"? It's a completely reasonably path to skip these tests and then come back later to fix them (if they matter), but I would suggest changing the PR title / commit message.

@bedevere-app
Copy link

bedevere-app bot commented Nov 23, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hoodmane
Copy link
Contributor Author

As a mathematician I have no right to call anyone pedantic under practically any circumstances.

@hoodmane hoodmane changed the title gh-127146 Emscripten: Fix segfaults in test suite gh-127146 Emscripten: Skip segfaults in test suite Nov 23, 2024
@hoodmane
pythongh-127146 Emscripten: Skip segfaults in test suite
c6425ea 
After this, Emscripten makes it all the way through the test suite when I run it
locally.
@hoodmane hoodmane force-pushed the fix-emscripten-test-segfaults branch from c11b73b to c6425ea Compare November 23, 2024 17:43
@hoodmane
Copy link
Contributor Author

Seems like I can remove a lot of these xfails if I set -sSTACK_SIZE=10mb instead of 5mb.

@hoodmane
Copy link
Contributor Author

Nevermind that is not true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdboom mdboom mdboom requested changes

@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner

@Eclips4 Eclips4 Awaiting requested review from Eclips4 Eclips4 is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@freakboy3742 freakboy3742 Awaiting requested review from freakboy3742

Assignees
No one assigned
Labels
awaiting changes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoodmane @mdboom @Eclips4