gh-127124: Add opaque pointer to context watcher callback #127140
+163
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables users to associate state with the callback without
relying on globals.
Also:
* Refactor the tests for improved readability and extensibility, and
to cover the new opaque pointer.
* Drop the pointer from the `PyContext_WatchCallback` typedef. This
de-obfuscates the fact that pointers are involved, and makes it
possible to forward-declare functions to improve readability:
static PyContext_WatchCallback my_callback;
int
my_callback(void *arg, PyContextEvent event, PyObject *obj)
{
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to associate state with the callback without relying on globals.
Also:
Refactor the tests for improved readability and extensibility, and to cover the new opaque pointer.
Drop the pointer from the
PyContext_WatchCallbacktypedef. This de-obfuscates the fact that pointers are involved, and makes it possible to forward-declare functions to improve readability:This will conflict with #124741; if one is merged I'll rebase the other.
📚 Documentation preview 📚: https://cpython-previews--127140.org.readthedocs.build/