Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 1-second join from threadexception plugin #13028

Closed
graingert opened this issue Dec 5, 2024 · 0 comments · Fixed by #13027
Closed

remove 1-second join from threadexception plugin #13028

graingert opened this issue Dec 5, 2024 · 0 comments · Fixed by #13027

Comments

@graingert
Copy link
Member

          I think it is a reasonable thing for someone to run some thread unrelated to pytest, like a monitoring thread or similar (there are many which do this), and then run `pytest.main()`. If I understand correctly, this would then cause an unnecessary 1s delay to the pytest run. Best case, they report a bug, worst case they just think pytest is slow and suffer through it.

So IMO, unless we can somehow restrict join_threads only to threads started by tests, we shouldn't do it.

Originally posted by @bluetech in #13016 (comment)

@graingert graingert changed the title remove 1 second join timeout from threadexception plugin remove 1-second join from threadexception plugin Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant