Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for UnitTest Style Tests #51

Open
Anjiang-Wei opened this issue Jul 30, 2021 · 7 comments
Open

Adding Support for UnitTest Style Tests #51

Anjiang-Wei opened this issue Jul 30, 2021 · 7 comments

Comments

@Anjiang-Wei
Copy link

I find the plugin pytest-flakefinder (https://github.com/dropbox/pytest-flakefinder), which seems to support UnitTest Style Tests already. You may want to refer to this file:
https://github.com/dropbox/pytest-flakefinder/blob/master/tests/test_flakefinder.py
Do you think it helpful for pytest-repeat?

@Anjiang-Wei
Copy link
Author

It appears that the tests augmented with pytest-flakefinder plugin do not repeat in a function mode. For example, if setting scope=function mode for pytest-repeat, test1's repeat should be: test1, test1 (consecutively). However, it appears to me that it does not seem to be the case in pytest-flakefinder.

@RonnyPfannschmidt
Copy link
Member

Unittest tests do not supported fixture parameterization, this won't change

@okken
Copy link
Contributor

okken commented Oct 5, 2023

@RonnyPfannschmidt Would this be reasonable to document, and then close, as it's not fixable?

@RonnyPfannschmidt
Copy link
Member

This ought to be documented as limitation imposed by the core unittesting plugin which doesn't support parameterization

@okken
Copy link
Contributor

okken commented Oct 5, 2023

Ah. It's already documented
I'm thinking a longer "Limitations" section in the README might be cool to cover this and any other items, like #21, but for now, this is already documented. This is in the README, but it's not obvious.

@okken
Copy link
Contributor

okken commented Oct 5, 2023

@RonnyPfannschmidt Thanks for your thoughts on these issues.

@RonnyPfannschmidt
Copy link
Member

If it's too easy to miss, maybe there is a way to make the reader stumble More to The point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants