Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Future Warnings for numpy, pandas, pysat #235

Merged
merged 10 commits into from
Jul 17, 2024

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Jul 16, 2024

Description

Updates usage based on future warnings raised in testing

  • For Series data, use ffill and bfill instead of fillna with a method.
  • Use .iloc for position data
  • Updates to pandas frequency strings
  • Usage of use_header in pysat

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

via pytest and inspecting messages.

Test Configuration:

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing marked this pull request as ready for review July 16, 2024 20:03
@jklenzing jklenzing requested a review from aburrell July 17, 2024 14:41
@jklenzing jklenzing merged commit c9d6fde into rc_0_0_6 Jul 17, 2024
17 of 23 checks passed
@jklenzing jklenzing deleted the maint/future_warn_2024 branch July 17, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants